AI Code Review

⚠️ Approved with suggestions — low-severity items only, safe to merge

What was reviewed

Skipped (out of scope): dist/, pnpm-lock.yaml

⚠️ CI check results could not be retrieved during this review — verify all checks are green before merging.

Findings

⚠️ Low — proposal.md documents wrong generic type

File: openspec/changes/fix-image-allow-upload-deprecation/proposal.md line 8
Note: The proposal says the typings change from DynamicValue<WebImage> to EditableImageValue<ImageValue>, but the actual generated ImageProps.d.ts and the Mendix API both use EditableImageValue<WebImage>. The runtime code and typings are correct; only the design doc is inconsistent. Worth correcting before this change is archived.

⚠️ Low — New container tests don't cover ValueStatus.Loading

File: packages/pluggableWidgets/image-web/src/__tests__/Image.spec.tsx lines 43–75
Note: The test guidelines require all Mendix data states to be covered (Available, Loading, Unavailable). The new spec covers Available and Unavailable but omits Loading. In Image.tsx a Loading imageObject silently falls through to an empty src — a test pin here would prevent regressions if that fallback is ever changed.

it("renders no image src when imageObject is Loading", () => {
    const { container } = render(
        <Image {...makeProps({ imageObject: makeImageValue({ status: ValueStatus.Loading, value: undefined }) })} />
    );
    const image = container.querySelector("img");
    expect(image?.getAttribute("src")).toBeFalsy();
});

⚠️ Low — Manual mock object instead of repo builders

File: packages/pluggableWidgets/image-web/src/__tests__/Image.spec.tsx lines 8–19
Note: The repo convention (per AGENTS.md and the test guidelines) is to use builders from @mendix/widget-plugin-test-utils rather than hand-rolled mock objects. EditableImageValue isn't directly covered by an existing builder, but the manual helper is fragile — if the EditableImageValue interface gains a new required field (e.g. Mendix 12 migration) the tests will silently cast around the gap via as ImageProp. At minimum, add a // EditableImageValue builder not yet available in test-utils comment so future authors know this was a conscious choice, or open a follow-up to add the builder to the shared package.

Positives

• Surgical change: only XML and generated typings modified; Image.tsx runtime logic left completely untouched — no risk of regressions in rendering or click behaviour
• CHANGELOG entry correctly calls out the raised minimum Mendix version, giving upgraders an immediate heads-up about the breaking floor change
• New container test file uses the factory-helper pattern (makeImageValue / makeProps) consistently — tests are readable and focused
• allowUpload="true" is the minimal, Mendix-prescribed fix for the deprecation; no new upload UI was introduced, keeping widget scope unchanged
• PR description documents manual Studio Pro 11.12 verification and explains why the Static image-source option is preserved — useful context for reviewers and future readers